Skip to content

Conversation

@kiner-tang
Copy link
Contributor

@kiner-tang kiner-tang commented Jun 9, 2023

@vercel
Copy link

vercel bot commented Jun 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
field-form ❌ Failed (Inspect) Jun 9, 2023 2:10pm

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #592 (95262a4) into master (8e88e23) will not change coverage.
The diff coverage is n/a.

❗ Current head 95262a4 differs from pull request most recent head a0204a7. Consider uploading reports for the commit a0204a7 to get more accurate results

@@           Coverage Diff           @@
##           master     #592   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files          15       15           
  Lines        1121     1121           
  Branches      238      254   +16     
=======================================
  Hits         1119     1119           
  Misses          2        2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@BoyYangzai BoyYangzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前的版本好像也能达到相同的效果
@kiner-tang

@kiner-tang
Copy link
Contributor Author

kiner-tang commented Jun 10, 2023

之前的版本好像也能达到相同的效果 @kiner-tang

RecursivePartial 这个工具如果在 rc-field-form 用看起来确实是正常的,但如果直接把这个工具原原本本拷贝到 antd 项目,就会发现上面的问题,应该是 rc-field-form 的 Typescript 版本跟 antd 不一致,应该是要以 antd 里面的为准。而且加 NonNullable 算是一个兜底,排除 undefined 的情况,如果不是 undefined , 不会有任何影响

@zombieJ zombieJ changed the title feat: optimize type definition fix: optimize type definition Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setFieldsValue method triggers a TypeScript type check error with optional fields

3 participants