-
-
Notifications
You must be signed in to change notification settings - Fork 280
fix: initialValue should trade as validate condition
#312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/field-form/611MM18gPPf7NT3cmAB2VJHiUmVo |
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 13 13
Lines 1006 1013 +7
Branches 230 232 +2
=======================================
+ Hits 1005 1012 +7
Misses 1 1
Continue to review full report at Codecov.
|
| { | ||
| "name": "rc-field-form", | ||
| "version": "1.21.0-1", | ||
| "version": "1.21.0-2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
版本号这样打,是有啥安排么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np 出问题了,本来是可以直接打 x.y.z-alpha.n,结果它输入不了文字只能选默认的预发版本号。就当 alpha 看就行了~~
|
需要升级 antd 吗? 升级到哪个版本呢? |
应该是月底的4.17.0 |
|
嗯呢,那月底我们再升级~ |
月底了哈~~ |
|
4.16.x的哪个版本已经发了 |
|
测试了下,在最新版本 4.16.6 中仍然是没有修复的,https://codesandbox.io/s/zhucexinyonghu-antd4163-forked-7vmvv?file=/index.js |
| public isFieldTouched = () => this.touched; | ||
|
|
||
| public isFieldDirty = () => this.dirty; | ||
| public isFieldDirty = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以考虑把this.dirty也暴露出来吗,
this.dirty || this.props.initialValue !== undefined不太符合需求
谢谢
resolve ant-design/ant-design#30995