Skip to content

Conversation

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 16, 2021

@vercel
Copy link

vercel bot commented Jun 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/field-form/611MM18gPPf7NT3cmAB2VJHiUmVo
✅ Preview: https://field-form-git-fix-initial-react-component.vercel.app

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #312 (fb1a843) into master (274dcd3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head fb1a843 differs from pull request most recent head b8e89b9. Consider uploading reports for the commit b8e89b9 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #312   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          13       13           
  Lines        1006     1013    +7     
  Branches      230      232    +2     
=======================================
+ Hits         1005     1012    +7     
  Misses          1        1           
Impacted Files Coverage Δ
src/FieldContext.ts 100.00% <ø> (ø)
src/useForm.ts 99.74% <ø> (ø)
src/Field.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 274dcd3...b8e89b9. Read the comment docs.

@zombieJ zombieJ merged commit b581a34 into master Jun 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-initial branch June 16, 2021 08:51
{
"name": "rc-field-form",
"version": "1.21.0-1",
"version": "1.21.0-2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

版本号这样打,是有啥安排么?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np 出问题了,本来是可以直接打 x.y.z-alpha.n,结果它输入不了文字只能选默认的预发版本号。就当 alpha 看就行了~~

@xiaofengqqcom123
Copy link

需要升级 antd 吗? 升级到哪个版本呢?
目前我们是 [email protected],最新版本向前兼容了吗?会有什么问题吗?

@yoyo837
Copy link
Member

yoyo837 commented Jun 18, 2021

需要升级 antd 吗? 升级到哪个版本呢?
目前我们是 [email protected],最新版本向前兼容了吗?会有什么问题吗?

应该是月底的4.17.0

@xiaofengqqcom123
Copy link

嗯呢,那月底我们再升级~

@xiaofengqqcom123
Copy link

需要升级 antd 吗? 升级到哪个版本呢?
目前我们是 [email protected],最新版本向前兼容了吗?会有什么问题吗?

应该是月底的4.17.0

月底了哈~~

@yoyo837
Copy link
Member

yoyo837 commented Jun 30, 2021

4.16.x的哪个版本已经发了

@xiaofengqqcom123
Copy link

测试了下,在最新版本 4.16.6 中仍然是没有修复的,https://codesandbox.io/s/zhucexinyonghu-antd4163-forked-7vmvv?file=/index.js

public isFieldTouched = () => this.touched;

public isFieldDirty = () => this.dirty;
public isFieldDirty = () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以考虑把this.dirty也暴露出来吗,
this.dirty || this.props.initialValue !== undefined不太符合需求
谢谢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dependencies not work in FormItem with initialValue

5 participants