feat: add move operation for List #20

hvsy · 2019-06-28T04:02:39Z

vercel · 2019-06-28T04:02:46Z

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://rc-field-form-git-fork-hvsy-master.react-component.now.sh

examples/StateForm-list.tsx

zombieJ · 2019-07-01T07:16:57Z

@hvsy

zombieJ · 2019-07-02T10:16:24Z

Could you help to create a new example named list-draggable instead?
And also, I test the example find that text can not be selectable:

Add list-draggable example

zombieJ · 2019-07-03T03:23:30Z

CI failed. Please check.

codecov · 2019-07-03T03:47:57Z

Codecov Report

Merging #20 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   99.85%   99.86%   +<.01%     
==========================================
  Files          13       13              
  Lines         698      720      +22     
  Branches      138      152      +14     
==========================================
+ Hits          697      719      +22     
  Misses          1        1

Impacted Files	Coverage Δ
src/List.tsx	`100% <100%> (ø)`	⬆️
src/utils/valueUtil.ts	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605bffe...2e99658. Read the comment docs.

examples/StateForm-list-draggable.tsx

zombieJ · 2019-07-03T10:02:53Z

sample seems laggy with user operation and drag not perf correctly:

remove console log for performance

hvsy · 2019-07-03T13:22:06Z

@zombieJ after remove console log and seems to work well so far.

package.json

src/utils/arrayMove.ts

rename "arrayMove" to "move". add checking for out of range. add test cases for out of range.

src/List.tsx

src/utils/valueUtil.ts

tests/utils.test.js

merge edge case check into one if.

hvsy · 2019-07-15T01:21:45Z

@zombieJ
Are there any suggestions for improvement?

zombieJ · 2019-07-15T01:55:55Z

examples/StateForm-list-draggable.tsx

+
+  return (
+    <DndProvider backend={HTML5Backend}>
+    <div>


miss 2 space as of child node.

zombieJ · 2019-07-15T01:57:18Z

examples/StateForm-list-draggable.tsx

+const { List, useForm } = Form;
+
+type LabelFieldProps = Parameters<typeof LabelField>[0];
+interface DraggableProps extends LabelFieldProps{


LabelFieldProps{ => LabelFieldProps {

Seems still missing types. Could you try to remove .git/hooks and reinstall node_modules to make father pre-commit hooks work. This will auto prettier the code when commit.

Please reference to following code. The default config don't include the examples directory.
so father pre-commit don't work for it.

https://github.com/umijs/father/blob/86e4eb154c212072cd937d6a87fd91762159e069/packages/father/src/preCommit.ts#L113

Let me add PR for this. Thanks for notice.

I add "examples" to the regex of pre-commit by manual. after then, I get following errors by exec "father pre-commit".

'react-dnd-html5-backend' and 'react-dnd' should only be used for example. it should be listed in devDependencies.

Thanks for feedback. Add PR for this: umijs/fabric#6

Updated @umi/fabric, please check.

tests/list.test.js

format draggable example

add move operation for List

b0ee9fd

vercel bot deployed to staging June 28, 2019 04:02 View deployment

zombieJ reviewed Jun 28, 2019

View reviewed changes

examples/StateForm-list.tsx Outdated Show resolved Hide resolved

Fixed format error

522ee30

vercel bot deployed to staging July 1, 2019 07:57 View deployment

Fixed format error

70288fb

vercel bot deployed to staging July 1, 2019 08:02 View deployment

Fixed input can not be selectable

7f1d951

Add list-draggable example

vercel bot deployed to staging July 3, 2019 02:30 View deployment

Fixed format for eslint

09eb435

vercel bot deployed to staging July 3, 2019 03:48 View deployment

add noneffective move test

bf47330

vercel bot deployed to staging July 3, 2019 04:04 View deployment

zombieJ reviewed Jul 3, 2019

View reviewed changes

examples/StateForm-list-draggable.tsx Outdated Show resolved Hide resolved

zombieJ reviewed Jul 3, 2019

View reviewed changes

examples/StateForm-list-draggable.tsx Outdated Show resolved Hide resolved

remove unnecessary action of draggable list example

4397bab

remove console log for performance

vercel bot deployed to staging July 3, 2019 13:20 View deployment

zombieJ reviewed Jul 4, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

remove lodash-move

077aba2

vercel bot deployed to staging July 4, 2019 07:58 View deployment

add test for array move function

3601dc6

vercel bot deployed to staging July 4, 2019 09:15 View deployment

zombieJ reviewed Jul 4, 2019

View reviewed changes

src/utils/arrayMove.ts Outdated Show resolved Hide resolved

zombieJ reviewed Jul 4, 2019

View reviewed changes

src/utils/arrayMove.ts Outdated Show resolved Hide resolved

zombieJ reviewed Jul 4, 2019

View reviewed changes

src/utils/arrayMove.ts Outdated Show resolved Hide resolved

move "arrayMove" function to valueUtil.ts file.

c348a27

rename "arrayMove" to "move". add checking for out of range. add test cases for out of range.

vercel bot deployed to staging July 5, 2019 01:41 View deployment

zombieJ reviewed Jul 5, 2019

View reviewed changes

src/List.tsx Show resolved Hide resolved

zombieJ reviewed Jul 5, 2019

View reviewed changes

src/utils/valueUtil.ts Show resolved Hide resolved

zombieJ reviewed Jul 5, 2019

View reviewed changes

tests/utils.test.js Show resolved Hide resolved

add more test cases for move function.

ae16986

merge edge case check into one if.

vercel bot deployed to staging July 5, 2019 03:07 View deployment

zombieJ reviewed Jul 15, 2019

View reviewed changes

examples/StateForm-list-draggable.tsx Outdated

return (

<DndProvider backend={HTML5Backend}>

<div>

Copy link

Member

zombieJ Jul 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss 2 space as of child node.

zombieJ reviewed Jul 15, 2019

View reviewed changes

tests/list.test.js Show resolved Hide resolved

zombieJ mentioned this pull request Jul 16, 2019

fix: example should list in dev deps umijs/fabric#6

Merged

upgrade father to latest

06167f3

format draggable example

vercel bot deployed to staging July 16, 2019 03:35 View deployment

add missing match key tests.

2e99658

vercel bot deployed to staging July 16, 2019 03:41 View deployment

zombieJ changed the title ~~add move operation for List~~ feat: add move operation for List Jul 16, 2019

zombieJ merged commit 0f48380 into react-component:master Jul 16, 2019

Uh oh!

feat: add move operation for List #20

feat: add move operation for List #20

Uh oh!

Conversation

hvsy commented Jun 28, 2019

Uh oh!

vercel bot commented Jun 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

zombieJ commented Jul 1, 2019

Uh oh!

zombieJ commented Jul 2, 2019

Uh oh!

zombieJ commented Jul 3, 2019

Uh oh!

codecov bot commented Jul 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

zombieJ commented Jul 3, 2019

Uh oh!

hvsy commented Jul 3, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hvsy commented Jul 15, 2019

Uh oh!

zombieJ Jul 15, 2019

Choose a reason for hiding this comment

Uh oh!

zombieJ Jul 15, 2019

Choose a reason for hiding this comment

Uh oh!

hvsy Jul 15, 2019

Choose a reason for hiding this comment

Uh oh!

zombieJ Jul 15, 2019

Choose a reason for hiding this comment

Uh oh!

hvsy Jul 16, 2019

Choose a reason for hiding this comment

Uh oh!

zombieJ Jul 16, 2019

Choose a reason for hiding this comment

Uh oh!

zombieJ Jul 16, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Jun 28, 2019 •

edited

Loading

codecov bot commented Jul 3, 2019 •

edited

Loading