Make library lintable using eastwood #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has no impact on normal usage, but allows for linting of the library with eastwood (since eastwood uses tools.analyzer.jvm, which is incompatible with macros that use Clojure's default &env).
|
Nice work! 👍 |
|
@razum2um Anything wrong with the PR? |
razum2um
added a commit
that referenced
this pull request
Apr 7, 2015
Make library lintable using eastwood
|
@cichli cool, besides, I haven't used eastwood before, thanks for that! |
|
@razum2um It'd be great if you can cut a new release for us. :-) |
|
@bbatsov 0.1.7 |
|
@razum2um thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first of all - thanks for open sourcing clj-debugger!
This patch fixes some warnings raised by the eastwood lint tool, and makes a slight modification to allow eastwood to lint the project (and any project dependent on it) without erroring.
The root of the problem is that
tools.analyzer, which eastwood uses to analyze Clojure code, provides an&envof a different shape to that ofclojure.lang.Compiler(see TANAL-13) - so we now filter out any key-value pairs that do not have a value of typeclojure.lang.Compiler$LocalBinding(i.e. for normal usage we filter out nothing; this only has an affect whentools.analyzerin play).