Doesn't seem to work

[gegoune]

Hi! I am quite keen to get try out this plugin, but as of now it doesn't work. Tried lua file with sumneko's lsp, and python with pyright; didn't get any popups with argument once in () after function call for neither of filetypes.

Installed with packer like that:

use {
  "neovim/nvim-lspconfig",
  requires = {
    {
      "kosayoda/nvim-lightbulb",
      config = function()
        vim.api.nvim_command("highlight LightBulbVirtualText guifg=red")
      end
    },
    "nvim-lua/lsp-status.nvim",
    {"ojroques/nvim-lspfuzzy", config = require "lspfuzzy".setup {}},
    {
      "ray-x/lsp_signature.nvim",
      config = function()
        require "lsp_signature".on_attach()
      end
    }
  }
}

I also have nvim-compe if that makes any difference.

[ray-x]

Thanks for trying this out.

Did a quick test with lua and python. It should work

Can you check if your 'textDocument/hover' or
'lua vim.lsp.buf.signature_help()' works when the cursor inside bracket?

Sometime when lsp can not find signature, pop up will not show. This may happen for the script where function definition is not strong typed.

my lua lsp config is here:
https://github.com/ray-x/dotfiles/blob/7e7709cdab3491e03a6f7fd5f96d13ac139cd865/lua/lsp_config.lua#L383

also pyls:
https://github.com/ray-x/dotfiles/blob/7e7709cdab3491e03a6f7fd5f96d13ac139cd865/lua/lsp_config.lua#L432

[gegoune]

Yes, calling lua vim.lsp.buf.signature_help() does show signature help, so it's there and working, just doesn't show up automatically. Perhaps some autocmd is missing?

[ray-x]

That is a bit wired.

require "lsp_signature".on_attach()

Should register the handler to Insert event.

One more thing to check:

I also exported the signature function, can you check if

lua require'lsp_signature'.signature()

give you same result of:

lua vim.lsp.buf.signature_help()

If it shows the same, that means the handler was not registered. If signature() also shows nothing, that there are other place need to check. So another thing to check is

require "lsp_signature".on_attach()
lua require'lsp_signature'.signature()

Togher to enforce on_attach to run again. I put my attach() in init.lua. Not sure it works same way in parker.

[gegoune]

Interesting, lua require'lsp_signature'.signature() returned nothing in both tests, that is, with and without (after) require "lsp_signature".on_attach().

Did double check and lua vim.lsp.buf.signature_help() showed signature.

Thanks for helping with debug!

[ray-x]

I just full back to a min config. It still works.

call plug#begin('~/.vim/plugged')
" Group dependencies, vim-snippets depends on ultisnips
Plug 'neovim/nvim-lspconfig'
Plug 'ray-x/lsp_signature.nvim'
call plug#end()

lua <<EOF
local nvim_lsp = require('lspconfig')
-- require('lsp_config')  -- you may need my lsp_config.lua
require('lsp_signature').on_attach()
local sumneko_root_path = vim.fn.expand("$HOME")..'/github/sumneko/lua-language-server'
local sumneko_binary = vim.fn.expand("$HOME")..'/github/sumneko/lua-language-server/bin/macOS/lua-language-server'
local on_attach = function(client, bufnr)
  require'lsp_signature'.on_attach()
  vim.api.nvim_buf_set_option(bufnr, 'omnifunc', 'v:lua.vim.lsp.omnifunc')
end

require'lspconfig'.sumneko_lua.setup {
  cmd = {sumneko_binary, "-E", sumneko_root_path .. "/main.lua"};
  on_attach = on_attach,
}
EOF

Can you send a minimum vimrc to reproduce the issue. I tried packer a few months before, but does not keep the configurations.

[ray-x]

Also tried following pack config vimrc it works as expected.

lua <<EOF

vim.cmd [[packadd packer.nvim]]
-- Only if your version of Neovim doesn't have https://github.com/neovim/neovim/pull/12632 merged
-- vim._update_package_paths()

require('packer').startup(function()
use {
  "neovim/nvim-lspconfig",
  "ray-x/lsp_signature.nvim",
}
end)

local nvim_lsp = require('lspconfig')
-- require('lsp_config')  -- you may need my lsp_config.lua
require('lsp_signature').on_attach()
local sumneko_root_path = vim.fn.expand("$HOME")..'/github/sumneko/lua-language-server'
local sumneko_binary = vim.fn.expand("$HOME")..'/github/sumneko/lua-language-server/bin/macOS/lua-language-server'
local on_attach = function(client, bufnr)
  require'lsp_signature'.on_attach()
end

require'lspconfig'.sumneko_lua.setup {
  cmd = {sumneko_binary, "-E", sumneko_root_path .. "/main.lua"};
  on_attach = on_attach,
}

EOF
let g:min_load = 1 "prevent other configure to load

[gegoune]

It works with minimal config, so something else in my configuration conflicts with your plugin. Will try to figure it out and come back to you. Thanks!

[gegoune]

It cut my configuration in many different ways, removed all plugins, settings and whatever else I could think of, but still no luck. Do you have any insight where to look exactly, as in, what could be stopping your plugin from working?

[ray-x]

It is really wired. Can you check if my minimum vimrc works for you or not?
Also, I am using kitty + mac.
Your issue looks like the event was hijacked and was not hooked.
Another thing is timer.
The code setup time in this plugin

timer:start(100, 200, vim.schedule_wrap(function()
...

This setup works for me. delay 100ms and refresh every 200ms.

And my timeout setting in vimrc:
timeoutlen = 500;
ttimeoutlen = 10;
updatetime = 100;
redrawtime = 1500;

The final check is to dump all InsertEnter/Leave registration in vim... That would be annoying to check the conflictions.

Also tried following pack config vimrc it works as expected.

lua <<EOF

vim.cmd [[packadd packer.nvim]]
-- Only if your version of Neovim doesn't have https://github.com/neovim/neovim/pull/12632 merged
-- vim._update_package_paths()

require('packer').startup(function()
use {
  "neovim/nvim-lspconfig",
  "ray-x/lsp_signature.nvim",
}
end)

local nvim_lsp = require('lspconfig')
-- require('lsp_config')  -- you may need my lsp_config.lua
require('lsp_signature').on_attach()
local sumneko_root_path = vim.fn.expand("$HOME")..'/github/sumneko/lua-language-server'
local sumneko_binary = vim.fn.expand("$HOME")..'/github/sumneko/lua-language-server/bin/macOS/lua-language-server'
local on_attach = function(client, bufnr)
  require'lsp_signature'.on_attach()
end

require'lspconfig'.sumneko_lua.setup {
  cmd = {sumneko_binary, "-E", sumneko_root_path .. "/main.lua"};
  on_attach = on_attach,
}

EOF
let g:min_load = 1 "prevent other configure to load

[gegoune]

Ah, no, problem definitely is within my configuration. Your minimal configuration with packer does work.

I am not sure if it is due to autocmd or not, but lua require'lsp_signature'.signature() returns nil when run on pcall(| (where | is cursor).

[ray-x]

Is your plugin is lazyloading? Try opt=false?

[gegoune]

No, it's not lazy loaded:

use {
  "neovim/nvim-lspconfig",
  requires = {
    {
      "kosayoda/nvim-lightbulb",
      config = function()
        vim.api.nvim_command("highlight LightBulbVirtualText guifg=red")
      end
    },
    "nvim-lua/lsp-status.nvim",
    {"ojroques/nvim-lspfuzzy", config = require "lspfuzzy".setup {}},
    "ray-x/lsp_signature.nvim"
  }
}

I then have require "lsp" in my init.lua sourcing lsp/init.lua with require "lsp_signature".on_attach() in custom on_attach() function which is called by every language server I have set up.

[ray-x]

Hi, @cloggier Can you send me your minium vimrc, hopefully, 1 or 2 files so I can reproduce your issue?

[talbergs]

Does not work for me also. Is it because I use compe?

[talbergs]

I may add this info - language server seems to provide this functionality.

  use {'neovim/nvim-lspconfig'}
  require'lspconfig'.intelephense.setup{
    on_attach = function(client, bufnr)
      print(vim.inspect(client.resolved_capabilities))
    end
  }

Outputs:

{
  call_hierarchy = false,
  code_action = false,
  code_lens = false,
  code_lens_resolve = false,
  completion = true,
  declaration = false,
  document_formatting = true,
  document_highlight = true,
  document_range_formatting = true,
  document_symbol = true,
  execute_command = false,
  find_references = true,
  goto_definition = true,
  hover = true,
  implementation = false,
  rename = false,
  signature_help = true,
  signature_help_trigger_characters = { "(", "," },
  text_document_did_change = 2,
  text_document_open_close = true,
  text_document_save = true,
  text_document_save_include_text = false,
  text_document_will_save = false,
  text_document_will_save_wait_until = false,
  type_definition = false,
  workspace_folder_properties = {
    changeNotifications = true,
    supported = true
  },
  workspace_symbol = true
}