Skip to content

Conversation

@aslonnie
Copy link
Collaborator

@aslonnie aslonnie commented Nov 19, 2025

adding -f flag in curl's, so that failure can be properly captured.

@aslonnie aslonnie requested a review from a team as a code owner November 19, 2025 00:43
@aslonnie aslonnie requested a review from abrarsheikh November 19, 2025 00:44
@aslonnie
Copy link
Collaborator Author

@abrarsheikh this will change the base from common py3.9 base to multipy base, and probably will fix the npm not found issue.

@aslonnie aslonnie requested a review from elliot-barn November 19, 2025 00:45
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the CI configuration to make the minbuild process multi-python aware. The changes are consistent across the affected rayci.yml files and the wanda.yaml build definition, and the logic appears sound. I have one suggestion to improve the maintainability of the min.build.wanda.yaml file by reducing duplication.

build_args:
- PYTHON_VERSION
- EXTRA_DEPENDENCY
- DOCKER_IMAGE_BASE_BUILD=cr.ray.io/rayproject/oss-ci-base_build-py$PYTHON_VERSION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line duplicates the base image URL from the froms field on line 2. To improve maintainability and avoid potential inconsistencies, consider defining this URL only once. If the wanda tool supports it, you could use a YAML anchor to define the URL in one place and reference it in both froms and build_args.

label: "wanda: minbuild-ml-py{{matrix}}"
wanda: ci/docker/min.build.wanda.yaml
depends_on: oss-ci-base_build
depends_on: oss-ci-base_build-multipy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: ML Group: Undeclared Build Dependency

The minbuild-ml step depends on oss-ci-base_build-multipy, but this dependency is not declared at the group level. The ml group's top-level depends_on should include oss-ci-base_build-multipy to ensure the build is available when minbuild-ml attempts to use it, matching the pattern in core.rayci.yml and serve.rayci.yml.

Fix in Cursor Fix in Web

label: "wanda: minbuild-ml-py{{matrix}}"
wanda: ci/docker/min.build.wanda.yaml
depends_on: oss-ci-base_build
depends_on: oss-ci-base_build-multipy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: ML Group: Standardize Build Dependencies

The ml group's top-level depends_on is missing oss-ci-base_build-multipy, even though the minbuild-ml step depends on it. This is inconsistent with the core and serve pipeline groups, which declare this dependency at the group level. The ml group should include oss-ci-base_build-multipy in its top-level depends_on to ensure proper dependency ordering and availability.

Fix in Cursor Fix in Web

@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Nov 19, 2025
@aslonnie aslonnie force-pushed the lonnie-251118-npmfix branch from 6dc6324 to e111abf Compare November 19, 2025 01:30
@ray-gardener ray-gardener bot added the devprod label Nov 19, 2025
@aslonnie aslonnie force-pushed the lonnie-251118-npmfix branch from e111abf to 01b1725 Compare November 19, 2025 01:45
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: minbuild-serve missing dependency on base multipy build

The minbuild-serve build step is missing a depends_on: oss-ci-base_build-multipy field. The min.build.wanda.yaml was updated to use multi-Python base images, and minbuild-ml was updated to explicitly depend on oss-ci-base_build-multipy. For consistency and correctness, minbuild-serve should have the same explicit dependency since it uses the same min.build.wanda.yaml template.

.buildkite/serve.rayci.yml#L26-L37

- name: minbuild-serve
label: "wanda: minbuild-{{matrix.extra}}-py{{matrix.python}}"
wanda: ci/docker/min.build.wanda.yaml
matrix:
setup:
python: ["3.10"]
extra: ["serve", "default"]
env:
PYTHON_VERSION: "{{matrix.python}}"
EXTRA_DEPENDENCY: "{{matrix.extra}}"
tags: cibase

Fix in Cursor Fix in Web


add `-f` flags, so that they will not fail silently

Signed-off-by: Lonnie Liu <[email protected]>
@aslonnie aslonnie force-pushed the lonnie-251118-npmfix branch from 69891be to 4209d32 Compare November 19, 2025 06:57
@aslonnie aslonnie changed the title [ci] fix minbuild multipy [ci] fix serve minbuild Nov 19, 2025
@aslonnie aslonnie merged commit ff4a546 into master Nov 19, 2025
5 of 6 checks passed
@aslonnie aslonnie deleted the lonnie-251118-npmfix branch November 19, 2025 08:06
aslonnie added a commit that referenced this pull request Nov 19, 2025
fix serve minbuild ci base image

Signed-off-by: Lonnie Liu <[email protected]>
aslonnie added a commit that referenced this pull request Nov 19, 2025
fix serve minbuild ci base image

Signed-off-by: Lonnie Liu <[email protected]>
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
adding `-f` flag in curl's, so that failure can be properly captured.

Signed-off-by: Lonnie Liu <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
400Ping pushed a commit to 400Ping/ray that referenced this pull request Nov 21, 2025
adding `-f` flag in curl's, so that failure can be properly captured.

Signed-off-by: Lonnie Liu <[email protected]>
ykdojo pushed a commit to ykdojo/ray that referenced this pull request Nov 27, 2025
adding `-f` flag in curl's, so that failure can be properly captured.

Signed-off-by: Lonnie Liu <[email protected]>
Signed-off-by: YK <[email protected]>
SheldonTsen pushed a commit to SheldonTsen/ray that referenced this pull request Dec 1, 2025
adding `-f` flag in curl's, so that failure can be properly captured.

Signed-off-by: Lonnie Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devprod go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants