[Core] Change many_actors release test frequency to nightly #58185
Conversation
Signed-off-by: Jiajun Yao <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request changes the many_actors release test frequency to nightly. This is a simple configuration change. My main feedback is regarding a potential inefficiency: the test's timeout is set to 60 minutes, while the PR description claims a runtime of less than 10 minutes. I recommend adjusting this timeout in a follow-up to better reflect the actual runtime, which would save resources and provide faster feedback on failures.
| working_dir: benchmarks | ||
|
|
||
| frequency: nightly-3x | ||
| frequency: nightly |
There was a problem hiding this comment.
The change to a nightly frequency is fine. However, there's a significant mismatch between the test's configured timeout and its reported runtime. The PR description states the test runs in under 10 minutes, but the timeout is set to 3600 seconds (60 minutes). If the test is indeed this fast, please consider lowering the timeout in a follow-up PR (e.g., to 1200s). A tighter timeout would prevent the 65-node cluster from being held unnecessarily in case of a hang, saving significant resources and providing quicker failure alerts.
ray-gardener
bot
added
core
|
what's the motivation? do you think it's a particularly high information test? |
|
This is the only test we have now for actor creation throughput. |
Have we seen frequent regressions or failures in the test? If not I'd suggest just leaving it at 3x per week. |
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
github-actions
bot
added
the
stale
|
This pull request has been automatically closed because there has been no more activity in the 14 days Please feel free to reopen or open a new pull request if you'd still like this to be addressed. Again, you can always ask for help on our discussion forum or Ray's public slack channel. Thanks again for your contribution! |
3 participants
Description
This test uses 65 nodes but only run for < 10 minutes so the cost is small.
Related issues
Additional information