[core] (cgroups 18/n) Moving the driver into the workers cgroup. #57776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: irabbani <[email protected]>
israbbani
added
core
israbbani
commented
Oct 16, 2025
| for line in leaf_cgroup_lines: | ||
| root_procs_file.write(line.strip()) | ||
| root_procs_file.flush() | ||
| # 3) Move the current process back into the _ROOT_CGROUP |
There was a problem hiding this comment.
This wasn't previously required because the Driver (for ray.init) was moved by the test script into the LEAF_CGROUP_ and never touched again.
However, now it will be moved by the raylet back into _TEST_CGROUP when ray stops.
Signed-off-by: irabbani <[email protected]>
… irabbani/cgroups-18 Signed-off-by: irabbani <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
… to calculate weights (#57800) This PR stacks on #57776. For more details about the resource isolation project see #54703. When Ray calculates the number of cpus available on the machine, it checks to see if it's running in a container. However, it truncates the number of cpus. In this PR, - If the number of CPUs on the machine is <= `DEFAULT_MIN_SYSTEM_RESERVED_CPU_CORES`, then raise a ValueError. Previously, this was < `DEFAULT_MIN_SYSTEM_RESERVED_CPU_CORES`. - Return fractional CPUs from `ray._private.utils.get_num_cpus` if an optional parameter is set to True. Signed-off-by: irabbani <[email protected]>
Signed-off-by: irabbani <[email protected]>
Signed-off-by: irabbani <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
israbbani
changed the title
edoakes
reviewed
Oct 16, 2025
python/ray/tests/resource_isolation/test_resource_isolation_integration.py
Outdated
Show resolved
Hide resolved
Signed-off-by: irabbani <[email protected]>
edoakes
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more details about the resource isolation project see #54703.
This PR moves the driver into the workers cgroup when it registers with the NodeManager. Also updates the tests to reflect this.
This now includes changes from #57800.