[Ready for review] updated template llamafactory-llm-fine-tune #57759
Conversation
Signed-off-by: as-jding <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This PR adds a note to the example notebooks about customizing training configurations. This is a helpful addition for users. However, the file paths provided in the notes are incorrect relative to the notebook's location. I've provided suggestions to correct these paths to match what's used in the example commands.
| "\n", | ||
| "### Configure LLaMA-Factory with Ray\n", | ||
| "\n", | ||
| "**Note**: To customize the training configuration, edit `train-configs/dpo_qlora.yaml`. \n", |
There was a problem hiding this comment.
The path to the configuration file seems incorrect. Later in the notebook (in the cell starting at line 214), the command used is llamafactory-cli train ../train-configs/dpo_qlora.yaml. This suggests the correct relative path from the notebook's directory is ../train-configs/dpo_qlora.yaml, not train-configs/dpo_qlora.yaml.
| "**Note**: To customize the training configuration, edit `train-configs/dpo_qlora.yaml`. \n", | |
| "**Note**: To customize the training configuration, edit `../train-configs/dpo_qlora.yaml`. \n", |
| "\n", | ||
| "### Configure LLaMA-Factory with Ray\n", | ||
| "\n", | ||
| "**Note**: To customize the training configuration, edit `train-configs/kto_lora.yaml`. \n", |
There was a problem hiding this comment.
The path to the configuration file seems incorrect. The command used later in this notebook (in the cell starting at line 231) is llamafactory-cli train ../train-configs/kto_lora.yaml. This suggests the correct relative path from the notebook's directory is ../train-configs/kto_lora.yaml, not train-configs/kto_lora.yaml.
| "**Note**: To customize the training configuration, edit `train-configs/kto_lora.yaml`. \n", | |
| "**Note**: To customize the training configuration, edit `../train-configs/kto_lora.yaml`. \n", |
| "### LLaMA-Factory + Ray configuration\n", | ||
| "### Configure LLaMA-Factory with Ray\n", | ||
| "\n", | ||
| "**Note**: To customize the training configuration, edit `train-configs/sft_lora_deepspeed.yaml`. \n", |
There was a problem hiding this comment.
The path to the configuration file seems incorrect. The command used later in this notebook (in the cell starting at line 308) is llamafactory-cli train ../train-configs/sft_lora_deepspeed.yaml. This suggests the correct relative path from the notebook's directory is ../train-configs/sft_lora_deepspeed.yaml, not train-configs/sft_lora_deepspeed.yaml.
| "**Note**: To customize the training configuration, edit `train-configs/sft_lora_deepspeed.yaml`. \n", | |
| "**Note**: To customize the training configuration, edit `../train-configs/sft_lora_deepspeed.yaml`. \n", |
Signed-off-by: as-jding <[email protected]>
ray-gardener
bot
added
docs
Signed-off-by: elliot-barn <[email protected]>
3 participants
Description
Added config files location reminder
Types of change
Checklist
Does this PR introduce breaking changes?
Testing:
Code Quality:
git commit -s)Documentation:
doc/source/(if applicable)