Skip to content

Conversation

@GeneDer
Copy link
Member

@GeneDer GeneDer commented Feb 24, 2025

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@GeneDer GeneDer added the go add ONLY when ready to merge, run all tests label Feb 24, 2025
@GeneDer
Copy link
Member Author

GeneDer commented Feb 24, 2025

@aslonnie
Copy link
Collaborator

seems that these tests use the cloud's resource in a pretty tight budget, when 2 or 3 sets of these tests are running concurrently, it will likely fail.

maybe we should add a buildkite concurrency group for them as a follow up.

@GeneDer
Copy link
Member Author

GeneDer commented Feb 24, 2025

serve_autoscaling_load_test.aws also passes.

@aslonnie aslonnie merged commit 8876a00 into ray-project:master Feb 24, 2025
5 checks passed
@GeneDer GeneDer deleted the fix-serve-release-test branch February 24, 2025 22:52
aslonnie added a commit that referenced this pull request Feb 24, 2025
Signed-off-by: Lonnie Liu <[email protected]>
GeneDer added a commit to GeneDer/ray that referenced this pull request Feb 24, 2025
required for running serve release tests now

Signed-off-by: Gene Su <[email protected]>
aslonnie added a commit that referenced this pull request Feb 24, 2025
fix 2 serve release tests.

Signed-off-by: Lonnie Liu <[email protected]>
kevin85421 pushed a commit to kevin85421/ray that referenced this pull request Feb 28, 2025
required for running serve release tests now

Signed-off-by: Gene Su <[email protected]>
Signed-off-by: kaihsun <[email protected]>
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Mar 4, 2025
required for running serve release tests now

Signed-off-by: Gene Su <[email protected]>
park12sj pushed a commit to park12sj/ray that referenced this pull request Mar 18, 2025
required for running serve release tests now

Signed-off-by: Gene Su <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-backlog go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants