-
Notifications
You must be signed in to change notification settings - Fork 664
[RayService] Directly fail CR if is invalid #4228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+84
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: win5923 <[email protected]>
win5923
commented
Nov 26, 2025
AndySung320
reviewed
Nov 27, 2025
machichima
reviewed
Nov 29, 2025
|
|
||
| // Create a namespace | ||
| namespace := test.NewTestNamespace() | ||
| rayServiceName := "rayservice-sample-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can we set the name with strings.Repeat("a", 48) to make it obvious that it exceed 48 characters?
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fix in 49c3b45.
Signed-off-by: win5923 <[email protected]>
e59fd41 to
49c3b45
Compare
rueian
approved these changes
Nov 29, 2025
400Ping
approved these changes
Nov 29, 2025
ryankert01
approved these changes
Nov 29, 2025
machichima
approved these changes
Nov 29, 2025
AndySung320
approved these changes
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Similar to #3980. We should directly fail the RayService CR when validation fails, rather than continuously requeueing.
kuberay/ray-operator/controllers/ray/rayservice_controller.go
Lines 112 to 116 in d59cbd8
Also add new RayServiceConditionReason called
RayServiceValidationFailed.Related issue number
Closes #4045
Checks