CMake: remove now not used nghttp2 dep #1211
Closed
+0
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2025
|
I believe active-development is now happening on the |
doronbehar
force-pushed
the
remove-nghttp2
branch
from
2eac6c9 to
e44ad1c
Compare
Done! |
|
Huh? curl.cmake: set(USE_NGHTTP2 ON CACHE BOOL "" FORCE) Why do you believe NGHTTP2 isn't being used, @doronbehar? |
|
Hmm OK I see. So since you build curl with nghttp2 support, you also need to build nghttp2. Because you don't use nghttp2 directly, I didn't notice this dependency is needed since on NixOS we insist using our dependencies. Our curl is built with nghttp2 so we haven't had any issues between rpi-imager and nghttp2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was part of #1175 .