drm/vc4: Force trigger of dlist update on margins change #4970
Conversation
When the margins are changed, the dlist needs to be regenerated with the changed updated dest regions for each of the planes. Setting the zpos_changed flag is sufficient to trigger that without doing a full modeset, therefore set it should the margins be changed. Signed-off-by: Dave Stevenson <[email protected]>
|
LGTM |
drivers/gpu/drm/vc4/vc4_crtc.c
Outdated
| vc4_state->margins.bottom = conn_state->tv.margins.bottom; | ||
| if (memcmp(&conn_state->tv.margins, &vc4_state->margins, | ||
| sizeof(vc4_state->margins))) { | ||
| vc4_state->margins.left = conn_state->tv.margins.left; |
There was a problem hiding this comment.
Why don't you use memcpy for the update, since memcmp is used for comparison? If the margins structure were to include an extra field then you would potentially detect the need for an update but not actually change anything.
There was a problem hiding this comment.
And if you do, swap the memcmp parameters so they match the memcpy.
There was a problem hiding this comment.
Yup, happy to do that.
I only kept the old code to reduce the diff, but memcpy makes more sense.
|
Something like this? |
|
Observation about Github PR handling. |
|
Strange that I've not seen that happen before - perhaps something about your privacy settings? I'll fix the patch for 5.16 and 5.17. |
…#4970) When the margins are changed, the dlist needs to be regenerated with the changed updated dest regions for each of the planes. Setting the zpos_changed flag is sufficient to trigger that without doing a full modeset, therefore set it should the margins be changed. Signed-off-by: Dave Stevenson <[email protected]>
3 participants
When the margins are changed, the dlist needs to be regenerated
with the changed updated dest regions for each of the planes.
Setting the zpos_changed flag is sufficient to trigger that
without doing a full modeset, therefore set it should the
margins be changed.
Signed-off-by: Dave Stevenson [email protected]
Requested by @spl237