Skip to content

Deprecate reading literal string in cudf.read_json #14619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

galipremsagar
Copy link
Contributor

Description

This PR deprecates reading literal strings in read_json, instead users will need to pass StringIO for these cases to silence the warning.

This change is to match: pandas-dev/pandas#53409

On pandas_2.0_feature_branch:

= 501 failed, 101106 passed, 2071 skipped, 786 xfailed, 312 xpassed, 20 errors in 1234.91s (0:20:34) =

This PR:

= 426 failed, 101181 passed, 2091 skipped, 786 xfailed, 312 xpassed in 1126.93s (0:18:46) =

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 12, 2023
@galipremsagar galipremsagar self-assigned this Dec 12, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner December 12, 2023 23:39
@galipremsagar galipremsagar requested review from vyasr, mroeschke and vuule and removed request for a team December 12, 2023 23:39
@galipremsagar galipremsagar added the 3 - Ready for Review Ready for review by team label Dec 12, 2023
@vuule
Copy link
Contributor

vuule commented Dec 13, 2023

Will this eventually remove the weird logic where pandas tries to read the input both as raw data and as file name?

@mroeschke
Copy link
Contributor

pandas has deprecated read_foo(data=... where data is "raw data" instead of a file in 2.1 IIRC, so when pandas 3.0 is the minimum supported version this can be removed

@galipremsagar galipremsagar merged commit d7dc16e into rapidsai:pandas_2.0_feature_branch Dec 13, 2023
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants