Skip to content

Deprecate method in fillna API #14278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2023
Merged

Deprecate method in fillna API #14278

merged 2 commits into from
Oct 13, 2023

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Oct 13, 2023 •
edited
Loading

Description

This PR deprecates method parameter in all public fillna APIs to match pandas: pandas-dev/pandas#53496

This PR:

= 1056 failed, 99098 passed, 2069 skipped, 776 xfailed, 312 xpassed, 20 errors in 670.87s (0:11:10) =

On pandas_2.0_feature_branch:

= 1584 failed, 98570 passed, 2069 skipped, 776 xfailed, 312 xpassed, 20 errors in 737.24s (0:12:17) =

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change deprecation labels Oct 13, 2023
@galipremsagar galipremsagar self-assigned this Oct 13, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner October 13, 2023 02:44
@galipremsagar galipremsagar requested review from wence- and charlesbluca and removed request for a team October 13, 2023 02:44
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 13, 2023
@galipremsagar galipremsagar merged commit 2461315 into rapidsai:pandas_2.0_feature_branch Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@mroeschke mroeschke mroeschke approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galipremsagar @wence- @mroeschke