Skip to content

GHA migration part 2: Remove drone spec, drop Drone CI #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andreas-kupries
Copy link
Contributor

Followup to #23, for rancher/rancher#44988

The PR #23 added the required GH action flows.
This PR now removes the Drone spec, dropping Drone CI.

@andreas-kupries andreas-kupries self-assigned this May 13, 2024
@samjustus samjustus requested a review from pmatseykanets May 15, 2024 15:02
@enrichman
Copy link

There are still a couple of Drone references:

Not sure about the Dapper one, but the first one will not work for sure. Are we using the version scripts somewhere in the CI?

@enrichman enrichman self-requested a review May 15, 2024 15:06
@andreas-kupries
Copy link
Contributor Author

There are still a couple of Drone references:

* https://github.com/rancher/kube-api-auth/blob/9814deb6ae4a9a2fdd0296eb771e743bbdfc0267/scripts/version#L8

* https://github.com/rancher/kube-api-auth/blob/9814deb6ae4a9a2fdd0296eb771e743bbdfc0267/Dockerfile.dapper#L12

We use scripts/version indirectly through scripts/build in the GHA flow.

The variable DRONE_TAG is one of the standard things set by the drone CI environment.
See https://docs.drone.io/pipeline/environment/reference/drone-tag/

While version tries to set GIT_TAG from DRONE_TAG, it does falls back to the git command when DRONE_TAG is empty or unset. That should be no trouble.

Further neither GIT_TAG nor VERSION are used in the flows.

@andreas-kupries andreas-kupries merged commit 1d27442 into rancher:master May 16, 2024
4 checks passed
@andreas-kupries andreas-kupries deleted the ak-44988-sure-7963-gh-actions-drop-drone branch May 16, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants