Skip to content

Migrate from Drone to GH Actions #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andreas-kupries
Copy link
Contributor

@andreas-kupries andreas-kupries commented Apr 11, 2024

Fix rancher/rancher#44988

Added draft GHA flows for test builds, and publication.

🚧 ⚠️ ⚠️ 🚧

  • Test the flows. Although unclear how to do that for the publication flow. The problem is less that it cannot be triggered for testing, enabling manual triggers handles that nicely. The issue is that the flow will push non-release images to the docker hub, which is very much not desired. That said, it also requires secrets, which we do not have yet.
  • Remove Drone spec

Ref https://github.com/rancherlabs/eio/issues/2165 for the migration of associated secrets

See https://hub.docker.com/r/rancher/kube-api-auth/tags
for where the images live on Docker Hub.


The publication flow (release.yml) was tested with PR #25.
The flow added here differs only in the trigger condition.
The test flow triggered on push_request whereas this here triggers on published release.

The action logs of the test run are at https://github.com/rancher/kube-api-auth/actions/runs/8738114342

The resulting image is at https://hub.docker.com/layers/rancher/kube-api-auth/pr-25/images/sha256-9f13ef730a7683a7eb91f1258d0129d5000a43c762605e234aa142d8f2a6d2fc
Its tag is pr-25, which was automatically chosen by the docker/metadata-action@v5, and is hopefully different enough to not be mistaken for a released version.

@andreas-kupries andreas-kupries added the enhancement New feature or request label Apr 11, 2024
@andreas-kupries andreas-kupries self-assigned this Apr 11, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@andreas-kupries andreas-kupries force-pushed the ak-44988-sure-7963-gh-actions branch from 5d63496 to b0f8909 Compare April 11, 2024 13:13
Copy link

@enrichman enrichman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

@andreas-kupries andreas-kupries force-pushed the ak-44988-sure-7963-gh-actions branch 3 times, most recently from 2566108 to 43855fe Compare April 18, 2024 09:01
@andreas-kupries andreas-kupries force-pushed the ak-44988-sure-7963-gh-actions branch from 9f0244d to 4b4c920 Compare April 18, 2024 12:00
This was referenced Apr 18, 2024
@andreas-kupries andreas-kupries merged commit 9814deb into rancher:master May 3, 2024
5 checks passed
@andreas-kupries andreas-kupries deleted the ak-44988-sure-7963-gh-actions branch August 5, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate rancher/kube-api-auth from Drone to GH Actions
4 participants