Instructions and Fixes #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moves styles to ionic2-datepicker.scss moves template to ionic2-datepicker.html adjust language and variables for weekdays list and months list
Changes code so that monthSelected() and yearSelected() do not select a specific date. Improves usability and prevents bug where disabled or out-of-range date could be selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bugs in
datepicker.tswhich throw errors.Adds instructions clarifying adaptation for Ionic 2
Adds default values for
this.config.fromDateandthis.config.toDateFixes bug with
prevMonth()andnextMonth()to avoid skipping months