Skip to content

Attempt to reduce flakiness of test/integration/instrumentation_test.rb #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

p-schlickmann
Copy link
Contributor

Hey @rosa

This is another attempt to reduce the flakiness of test/integration/instrumentation_test.rb

I ran this locally and had no flakiness in the 100 attempts:

for i in {1..100}; do bin/rails test test/integration/instrumentation_test.rb || break; done

Previous attempts so far: f433a99
Issue: #602

scheduler.stop
end

assert events.size >= 1
event = events.last
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the async nature of Solid Queue it seems like we can't use .last reliably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant