Removed needless json dependency and drop to support Ruby 1.8 #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Bump. I can't work on Rails master with trunk Ruby because the JSON that sdoc depends on won't compile. |
Contributor
Author
|
Note: We've released rdoc-5.0.0.beta2 fixed json dependency with Ruby 2.4.0 |
Member
|
@hsbt @tenderlove Whoops! I cut a pre-release which hopefully fixes this. <3 |
This was referenced Oct 8, 2016
sanemat
referenced
this pull request
in sanemat/openid_connect
Jul 29, 2017
Use bundled gem directly see https://github.com/zzak/sdoc/pull/96 ruby/rdoc#412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is same reason as ruby/rdoc#412
And also needs bump version rdoc 5.0, I think.