Skip to content

Conversation

@ecentell-CPF
Copy link
Contributor

Prepare for 2.1.6

Prepare for 2.1.6
Append PRE
@ecentell-CPF
Copy link
Contributor Author

Looks like the artifact issue is fixed via PR #541 which was mentioned as a prerequisite (#533 ) to this PR. Can we move ahead @aharpervc @andyundso

@andyundso
Copy link
Member

I would leave this PR to @aharpervc , as he has ultimately permissions to publish a new gem version. but the PR itself looks good to me.

@andyundso andyundso requested a review from aharpervc October 19, 2023 07:42
@ecentell-CPF
Copy link
Contributor Author

Hello @aharpervc any chance to look into this?

@aharpervc
Copy link
Contributor

Yeah, seems fine to me. I don't see the gem files on the artifacts page in CircleCI, though. It seems prudent to push 2.1.6.pre to rubygems before merging this branch. Thoughts?

@ecentell-CPF
Copy link
Contributor Author

@andyundso can you comment on the disposition of the artifacts? I second the approach of getting the push to rubygems so I can test that side of the equation.

@andyundso
Copy link
Member

Three things.

First, I think I never added artifact upload for the "plain" gem, like used in the Linux tests, only the platform-specific versions from Windows.

Second, CircleCI appears to delete artifacts after 30 days.

After 30 days, all artifacts associated with a build automatically expire. Since this run is over 30 days old, the artifacts may have been deleted.

I just re-run the pipeline on the master branch, and there the artifacts appear again, e.g. here.

Third, your branch is behind, so even if you re-run your build, the Windows artifacts will not appear as the fix from #541 is not included.

@ecentell-CPF
Copy link
Contributor Author

Thank you for pointing out the branch needing a refresh, I have finished the re sync.

@ecentell-CPF
Copy link
Contributor Author

ecentell-CPF commented Nov 13, 2023

@aharpervc I see the artifacts for the windows gems in Circle now, can you verify on your side?

(edited for clarity)

@ecentell-CPF
Copy link
Contributor Author

Hello @aharpervc any chance to look into this?

@andyundso andyundso merged commit 5a75464 into rails-sqlserver:master Dec 3, 2023
@andyundso
Copy link
Member

@ecentell-CPF I will do some final tests until Tuesday and then release 2.1.6 to RubyGems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants