Change identity columns to use direct SQL query when cross database #1356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrisortman The test cases are too low level. They don't show the inserting issue you are having or whether the issue has been fixed by your changes. Could you review #1357 and let me know if that recreates the exact error you are encountering? |
|
@aidanharan Yes that reproduces the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #1355
When trying to get identity columns, schema_cache is only valid if the database you are inserting into is the database you are connected to.
This change checks the table to see if it is database qualified and if so does a direct query to get identity columns using the system schema of the target database.
When target database is current database I preserved the old behavior so that it does not suddenly introduce an extra query for every insert. This also keeps the active record tests happy.
I did the fix against 7.2 stable because that is what I am currently running my my prod apps. If we can figure out if this is the correct approach I can port it to 8 and main as well.