Avoid wrapping 5 when contracted as (Sequenceof Integer). #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennn
reviewed
Nov 6, 2017
| [(Sequence: (list t)) | ||
| #:when (subtype t:-Nat t) | ||
| ;; sequence/c is always a wrapper, so avoid it when we just have a number | ||
| (or/sc (flat/sc #'exact-nonnegative-integer?) |
Contributor
There was a problem hiding this comment.
We should merge #631 first, because with this change and without that PR, every (Sequence T) type in a "trusted positive position" is going to optimize to an any/c contract.
(or/sc (flat/sc ....) (sequence/sc ....))
=>
(or/sc any/c (sequence/sc ....))
=>
any/c
Contributor
There was a problem hiding this comment.
(Even though sequences are read-only, this is a problem if T is something like (Boxof Int))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes racket/math#13