-
-
Notifications
You must be signed in to change notification settings - Fork 104
Let typed/racket/no-check export racket/base at phase level 1.
#1224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you say something (preferably in a comment in the files) about why you need the additional changes beyond the first one? |
|
|
|
On the first commit I simply let
The simplest and most straightforward solution I can think of is to make these languages implement the corresponding And I'm not quite sure how to add a comment, since the |
|
This change broke the "rosetta" (see https://plt.cs.northwestern.edu/pkg-build/server/built/fail/rosetta.txt) because apparently Here's an example: |
A recent change to Typed Racket (racket/typed-racket#1224) caused some unintentionally-exported identifiers from `typed/racket` to be no longer provided by `typed/racket/base/no-check`. We will fix this change, but this commit imports those identifiers from the correct place.
|
In fact, I think all of |
Unfortunately this was accidentally done previously, and fixing it in racket#1224 unfortunately broke existing code.
) Unfortunately this was accidentally done previously, and fixing it in #1224 unfortunately broke existing code.
Closes #1223.