Skip to content

Conversation

@capfredf
Copy link
Member

@capfredf capfredf commented Feb 8, 2021

use the same spec to generate types for them.

closes #1039

@capfredf capfredf force-pushed the fix-1038 branch 2 times, most recently from 96a3ffb to d89428c Compare February 9, 2021 19:13
@capfredf capfredf requested a review from samth February 9, 2021 19:58
@samth
Copy link
Member

samth commented Feb 9, 2021

We talked and planned to try more random testing on this.

use the same spec to generate types for them. Also do random testing on quotient/remainder

closes racket#1039
@capfredf
Copy link
Member Author

@samth I have made changes to tr-randoming-testings.rkt. I increased the number of the first two tests to 2000 to make sure the generated expressions does include quotient, remainder, quotient/remainder

@capfredf capfredf merged commit d3183fc into racket:master Feb 10, 2021
@wargrey
Copy link
Contributor

wargrey commented Feb 15, 2021

Hello, @capfredf @samth. this PR seems to forget the case of (-> Index Byte Byte).

In original code, there are also no cases of (-> Nonnegative-Fixnum Byte Byte) and (-> Natural Byte Byte), but typed racket seems smart enough to deal with them when the second argument is of Byte.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Types of quotient/remainder and remainder are not consistent

3 participants