improves error reporting for (list ....)
#1030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samth
reviewed
Jan 25, 2021
capfredf
force-pushed
the
fix-995
branch
4 times, most recently
from
70c2c54 to
1a8f439
Compare
The commit contains the following changes: 1. When the expected type is `(Listof t)`, we use `t` to check the arguments to `list` 2. In a more complexed situation, when some arguments `(list arg ...)` are ill-typed, the typechecker reports the error without checking if the result type of the function application matches the expected type. closes racket#995 and racket#958
samth
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #995 and #958