fix the types fo LVof #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
related to racket/typed-racket#1143 |
change those types to be forward-compatible with TR's upcoming changes where polymorphic types are no longer replacements of type constructors
Collaborator
|
This looks good to me. @samth , is this change OK to merge? If it is I will merge it and also put it on the release branch to make it into 8.3. |
Member
Author
|
@alex-hhh it should be fine. The change I made is compatible with all past and current version of Typed Racket where |
Collaborator
|
OK, I merged it down, but will not add this change to the release branch so it won't be in 8.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change those types to be forward-compatible with TR's upcoming changes where
polymorphic types are not replacements of type constructors any more.