Do not escape erlc_opts in erlang_bytecode2 rule #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoloRin
force-pushed
the
no-escape-erl-opts-erlang_bytecode2
branch
from
8577822 to
a9a6e26
Compare
HoloRin
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Feb 15, 2023
Should be unnecessary once rabbitmq/rules_erlang#140 is available in a release
mergify bot
pushed a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Feb 16, 2023
Should be unnecessary once rabbitmq/rules_erlang#140 is available in a release (cherry picked from commit b6e145c)
mergify bot
pushed a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Feb 16, 2023
Should be unnecessary once rabbitmq/rules_erlang#140 is available in a release (cherry picked from commit b6e145c) (cherry picked from commit d646ea4)
HoloRin
force-pushed
the
no-escape-erl-opts-erlang_bytecode2
branch
from
e17b5ab to
1013748
Compare
This this allows "-I some/path/*" style opts to work
to avoid generating incorrect erlc_opts
HoloRin
force-pushed
the
no-escape-erl-opts-erlang_bytecode2
branch
from
1013748 to
fe0acaf
Compare
HoloRin
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Feb 17, 2023
Should be unnecessary once rabbitmq/rules_erlang#140 is available in a release (cherry picked from commit b6e145c) (cherry picked from commit d646ea4)
HoloRin
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Feb 17, 2023
* Regenerate bazel/BUILD.eetcd with the latest rules_erlang `bazel run gazelle -- update-repos --verbose --build_files_dir=bazel hex.pm/[email protected]` Related to #7196 (cherry picked from commit 2dc0236) (cherry picked from commit 733aad5) # Conflicts: # MODULE.bazel # WORKSPACE * Remove extra erlc_opts from BUILD.eetcd Should be unnecessary once rabbitmq/rules_erlang#140 is available in a release (cherry picked from commit b6e145c) (cherry picked from commit d646ea4) * Update the note about eetcd and dialyzer now that the original issue has been resolved. We cannot bump gun just yet, as eetcd is not yet compatible with gun 2.0.0 zhongwencool/eetcd#28 zhongwencool/eetcd#55 (cherry picked from commit 185e910) (cherry picked from commit 31f5eec) * Adjust the size of //deps/rabbit:bindings_SUITE to medium generally speaking, rabbitmq_integration_suite tests do not reliably run in under the 60s timeout implied by "small", at least in CI (cherry picked from commit 60093ee) (cherry picked from commit d56f004) # Conflicts: # deps/rabbit/BUILD.bazel * Add missing dep to //deps/rabbitmq_aws:eunit test (cherry picked from commit 1bef97a) (cherry picked from commit 60d09a3) * Additional conflict resolution --------- Co-authored-by: Rin Kuryloski <[email protected]>
mergify bot
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Feb 17, 2023
* Regenerate bazel/BUILD.eetcd with the latest rules_erlang `bazel run gazelle -- update-repos --verbose --build_files_dir=bazel hex.pm/[email protected]` Related to #7196 (cherry picked from commit 2dc0236) (cherry picked from commit 733aad5) # Conflicts: # MODULE.bazel # WORKSPACE * Remove extra erlc_opts from BUILD.eetcd Should be unnecessary once rabbitmq/rules_erlang#140 is available in a release (cherry picked from commit b6e145c) (cherry picked from commit d646ea4) * Update the note about eetcd and dialyzer now that the original issue has been resolved. We cannot bump gun just yet, as eetcd is not yet compatible with gun 2.0.0 zhongwencool/eetcd#28 zhongwencool/eetcd#55 (cherry picked from commit 185e910) (cherry picked from commit 31f5eec) * Adjust the size of //deps/rabbit:bindings_SUITE to medium generally speaking, rabbitmq_integration_suite tests do not reliably run in under the 60s timeout implied by "small", at least in CI (cherry picked from commit 60093ee) (cherry picked from commit d56f004) # Conflicts: # deps/rabbit/BUILD.bazel * Add missing dep to //deps/rabbitmq_aws:eunit test (cherry picked from commit 1bef97a) (cherry picked from commit 60d09a3) * Additional conflict resolution --------- Co-authored-by: Rin Kuryloski <[email protected]> (cherry picked from commit 6be0b49) # Conflicts: # deps/rabbitmq_peer_discovery_etcd/BUILD.bazel
HoloRin
pushed a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Feb 17, 2023
* Regenerate bazel/BUILD.eetcd with the latest rules_erlang `bazel run gazelle -- update-repos --verbose --build_files_dir=bazel hex.pm/[email protected]` Related to #7196 (cherry picked from commit 2dc0236) (cherry picked from commit 733aad5) # Conflicts: # MODULE.bazel # WORKSPACE * Remove extra erlc_opts from BUILD.eetcd Should be unnecessary once rabbitmq/rules_erlang#140 is available in a release (cherry picked from commit b6e145c) (cherry picked from commit d646ea4) * Update the note about eetcd and dialyzer now that the original issue has been resolved. We cannot bump gun just yet, as eetcd is not yet compatible with gun 2.0.0 zhongwencool/eetcd#28 zhongwencool/eetcd#55 (cherry picked from commit 185e910) (cherry picked from commit 31f5eec) * Adjust the size of //deps/rabbit:bindings_SUITE to medium generally speaking, rabbitmq_integration_suite tests do not reliably run in under the 60s timeout implied by "small", at least in CI (cherry picked from commit 60093ee) (cherry picked from commit d56f004) # Conflicts: # deps/rabbit/BUILD.bazel * Add missing dep to //deps/rabbitmq_aws:eunit test (cherry picked from commit 1bef97a) (cherry picked from commit 60d09a3) * Additional conflict resolution --------- Co-authored-by: Rin Kuryloski <[email protected]> (cherry picked from commit 6be0b49) # Conflicts: # deps/rabbitmq_peer_discovery_etcd/BUILD.bazel
HoloRin
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Feb 17, 2023
* Regenerate bazel/BUILD.eetcd with the latest rules_erlang `bazel run gazelle -- update-repos --verbose --build_files_dir=bazel hex.pm/[email protected]` Related to #7196 (cherry picked from commit 2dc0236) (cherry picked from commit 733aad5) * Remove extra erlc_opts from BUILD.eetcd Should be unnecessary once rabbitmq/rules_erlang#140 is available in a release (cherry picked from commit b6e145c) (cherry picked from commit d646ea4) * Update the note about eetcd and dialyzer now that the original issue has been resolved. We cannot bump gun just yet, as eetcd is not yet compatible with gun 2.0.0 zhongwencool/eetcd#28 zhongwencool/eetcd#55 (cherry picked from commit 185e910) (cherry picked from commit 31f5eec) * Adjust the size of //deps/rabbit:bindings_SUITE to medium generally speaking, rabbitmq_integration_suite tests do not reliably run in under the 60s timeout implied by "small", at least in CI (cherry picked from commit 60093ee) (cherry picked from commit d56f004) * Add missing dep to //deps/rabbitmq_aws:eunit test (cherry picked from commit 1bef97a) (cherry picked from commit 60d09a3) * Additional conflict resolution --------- Co-authored-by: Rin Kuryloski <[email protected]> (cherry picked from commit 6be0b49)
HoloRin
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Feb 17, 2023
#7329) (#7352) * Use the latest rules_erlang (backport #7315) (backport #7327) (#7329) * Regenerate bazel/BUILD.eetcd with the latest rules_erlang `bazel run gazelle -- update-repos --verbose --build_files_dir=bazel hex.pm/[email protected]` Related to #7196 (cherry picked from commit 2dc0236) (cherry picked from commit 733aad5) * Remove extra erlc_opts from BUILD.eetcd Should be unnecessary once rabbitmq/rules_erlang#140 is available in a release (cherry picked from commit b6e145c) (cherry picked from commit d646ea4) * Update the note about eetcd and dialyzer now that the original issue has been resolved. We cannot bump gun just yet, as eetcd is not yet compatible with gun 2.0.0 zhongwencool/eetcd#28 zhongwencool/eetcd#55 (cherry picked from commit 185e910) (cherry picked from commit 31f5eec) * Adjust the size of //deps/rabbit:bindings_SUITE to medium generally speaking, rabbitmq_integration_suite tests do not reliably run in under the 60s timeout implied by "small", at least in CI (cherry picked from commit 60093ee) (cherry picked from commit d56f004) * Add missing dep to //deps/rabbitmq_aws:eunit test (cherry picked from commit 1bef97a) (cherry picked from commit 60d09a3) * Additional conflict resolution --------- Co-authored-by: Rin Kuryloski <[email protected]> (cherry picked from commit 6be0b49) * thoas -> jsx --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Rin Kuryloski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows more flexibility in providing options, at the cost of needing to explicitly provide them in escaped form in some cases