-
Notifications
You must be signed in to change notification settings - Fork 48
Resolve address via a function #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve address via a function #431
Conversation
… return an Endpoint
Thank you, @vcostet. Can you please check the CI errors? |
Should be good, at least for the build part. I put back the Endpoint attribute to public on AddressResolver. |
Hi @vcostet 👋 Thank you for contributing to this client. Recently (a month ago) our company did some changes around open source contribution, and now it's required that you sign a contributor license agreement (CLA) before we can accept your PR. The process is explained here in this repo README: https://github.com/rabbitmq/cla Would you review and sign this CLA? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking merge on CLA signing. Code looks good.
Sorry @vcostet, if you can't sign the CLA, I am afraid I have to close the PR. |
Hi, I didn't mention it here, but I have signed it on Sept. 23. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLA received on September 23rd, thank you! It took us a bit to correlate the signing with this PR 🙃
Similarly to what's done on the java client (here), add a way to resolve addresses using a function, instead of a static value.
AddressResolver
attribute onStreamSystemConfig
has been changed to an interface, so the existingAddressResolver
class can still be used.