Skip to content
This repository was archived by the owner on Nov 18, 2020. It is now read-only.

Conversation

@michaelklishin
Copy link
Contributor

Proposed Changes

This introduces support for a number of stomp.tcp_listen_options.* settings in the new
style config format. They mimic tcp_listen_options.* available for AMQP 0-9-1 and AMQP 1.0 listeners.

Types of Changes

  • Bugfix (non-breaking change which fixes issue Support more TCP listener options #129)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Closes #129.

[#157922235]

That mimic tcp_listen_options.* for AMQP 0-9-1 and AMQP 1.0 listeners.

Closes #129.

[#157922235]
@michaelklishin
Copy link
Contributor Author

Config file that can be used for QA:

stomp.listeners.tcp.1 = 127.0.0.1:61613
stomp.listeners.tcp.2 = ::1:61613

stomp.tcp_listen_options.backlog = 2048
stomp.tcp_listen_options.recbuf = 8192
stomp.tcp_listen_options.sndbuf = 8192

stomp.tcp_listen_options.keepalive = true
stomp.tcp_listen_options.nodelay   = true

stomp.tcp_listen_options.exit_on_close = true

stomp.tcp_listen_options.send_timeout = 120

michaelklishin added a commit to rabbitmq/rabbitmq-mqtt that referenced this pull request Jan 2, 2019
The settings are already supported by this plugin.

(cherry picked from commit e571af2)
@lukebakken lukebakken merged commit da33e26 into master Jan 2, 2019
@lukebakken lukebakken deleted the rabbitmq-stomp-129 branch January 2, 2019 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support more TCP listener options

3 participants