Skip to content

Conversation

@HoloRin
Copy link
Contributor

@HoloRin HoloRin commented Feb 16, 2023

rules_erlang 3.9.5+ generates "compact" rules when running update-repos

this speeds up the cold build, since fewer erlc actions are run, and since external deps typically don't change incrementally, the value of having a bazel rule per file is miminal

rules_erlang 3.9.5+ generates "compact" rules when running
update-repos

this speeds up the cold build, since fewer erlc actions are run, and
since external deps typically don't change incrementally, the value of
having a bazel rule per file is miminal
@HoloRin HoloRin marked this pull request as ready for review February 16, 2023 18:36
@michaelklishin michaelklishin merged commit 6976b72 into main Feb 16, 2023
@michaelklishin michaelklishin deleted the rin/rebuild-build-files-for-deps branch February 16, 2023 20:44
HoloRin added a commit that referenced this pull request Feb 20, 2023
… (backport #7343) (backport #7344) (#7345)

* Rebuild bazel/BUILD.* files with recent rules_erlang

rules_erlang 3.9.5+ generates "compact" rules when running
update-repos

this speeds up the cold build, since fewer erlc actions are run, and
since external deps typically don't change incrementally, the value of
having a bazel rule per file is miminal

(cherry picked from commit 5cb434f)
(cherry picked from commit 279efd6)
(cherry picked from commit fc29e3b)

* Turn off +warnings_as_errors in redbug dep

(cherry picked from commit e7cddb0)
(cherry picked from commit 88036da)
(cherry picked from commit 17d2182)

* Adjust bazel/BUILD.emqtt

until rabbitmq/rules_erlang#147 is released

(cherry picked from commit 36a4b5b)
(cherry picked from commit b39791b)
(cherry picked from commit 283ac3b)

* Regenerate bazel/BUILD.jsx

* Regenerate bazel/BUILD.jose

without thoas integration

---------

Co-authored-by: Rin Kuryloski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants