Skip to content

Conversation

@ansd
Copy link
Member

@ansd ansd commented Feb 13, 2023

Remove compatibility code for feature flag stream_queue because this feature flag is required in 3.12.

See #7219

@ansd ansd added this to the 3.12.0 milestone Feb 13, 2023
Remove compatibility code for feature flag `stream_queue`
because this feature flag is required in 3.12.

See #7219
@michaelklishin michaelklishin merged commit 054381a into main Feb 14, 2023
@michaelklishin michaelklishin deleted the ff-stream_queue branch February 14, 2023 01:35
@dumbbell
Copy link
Collaborator

The rabbit_queue_type:is_enabled() part seems useful for future queues types, even though all queue types are supported today. @ansd: What do you think?

@ansd
Copy link
Member Author

ansd commented Feb 14, 2023

I was previously thinking about the same and decided it's better to delete unused code and add it back in case we have a new queue type in the future.
But it seems that you also find it useful. So, I'm going to add it back :)

ansd added a commit that referenced this pull request Feb 14, 2023
This commits partially reverts 575f4e7

Function `rabbit_queue_type:is_enabled/1` seems to be useful for future
queue types.

See #7269 (comment)
mergify bot pushed a commit that referenced this pull request Feb 14, 2023
This commits partially reverts 575f4e7

Function `rabbit_queue_type:is_enabled/1` seems to be useful for future
queue types.

See #7269 (comment)

(cherry picked from commit 97634e9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants