Skip to content

Conversation

@dumbbell
Copy link
Collaborator

@dumbbell dumbbell commented Feb 8, 2023

I got random failures from this testsuite:

  • function_clause exceptions in the broker
  • failure of the "invalid regex patterns" testcase

Follow-up to #7197.

Otherwise the command causes a `function_clause` exception in the broker
because a `nil` atom is passed as the username instead of a binary.
…est expectations

Testcases are executed in a random order. Unfortunately, this testcase
depended on side effects of other testcases. If this testcase was
executed first, then there were no permissions set and the testcase
would fail.

It now lists permissions before and after the actual test and compare
both.
@dumbbell dumbbell self-assigned this Feb 8, 2023
@dumbbell dumbbell marked this pull request as ready for review February 8, 2023 09:43
@dumbbell dumbbell merged commit 8b88e45 into main Feb 8, 2023
@dumbbell dumbbell deleted the fix-set_permissions_globally-testsuite branch February 8, 2023 09:50
dumbbell added a commit that referenced this pull request Feb 8, 2023
Fix `set_permissions_globally` testsuite (backport #7213)
@dumbbell dumbbell added this to the 3.12.0 milestone Feb 8, 2023
dumbbell added a commit that referenced this pull request Feb 8, 2023
Fix `set_permissions_globally` testsuite (backport #7213) (backport #7215)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants