x.509 certificate username extraction: decode other name as directory strings #2985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of specific ones since they will vary with the payload (one of them likely indicates UTF string length). This is still not perfect because we limit the maximum allowed length but it works fine with identifiers up to 100 characters long, which should be good enough for this best effort handling of an abscure SAN type. References ##2983.
and assume it is a string-like value ("directory string")
because other values would not make much sense in the
username extraction context.
References #2983.
michaelklishin
changed the title
|
Using the following otherName = 1.3.6.1.4.1.54392.5.436;FORMAT:UTF8,UTF8String:unicøde-vàlüeI can tell that it is parsed correctly on this branch. It also authenticates when I create a user and grant it some permissions: rabbitmqctl add_user "unicøde-vàlüe"
rabbitmqctl set_permissions -p / "unicøde-vàlüe" ".*" ".*" ".*"I also tested with some Cyrillic and ASCII values ranging from 4 to 390 bytes in length. |
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decode other name using 'OTP-PUB-KEY':decode/2
and assume it is a string-like value ("directory string")
because other values would not make much sense in the
username extraction context.
References #2983, follow-up to #2984.