Skip to content

Conversation

@gerhard
Copy link
Contributor

@gerhard gerhard commented Apr 23, 2019

RabbitMQ supports both power of 2 & power of 10 unit symbols. Giving clear examples of the difference - it's a mistake easy to make.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Pushed this commit into master first, by mistake, had to revert.

RabbitMQ supports both power of 2 & power of 10 unit symbols. Giving
clear examples of the difference - it's a mistake easy to make.
@michaelklishin
Copy link
Collaborator

We have @dcorbacho's approval since we are pairing :)

@michaelklishin michaelklishin merged commit 314b644 into master Apr 23, 2019
@michaelklishin michaelklishin deleted the clarify_si_unit_symbols branch April 23, 2019 15:45
@michaelklishin michaelklishin added this to the 3.7.15 milestone Apr 23, 2019
michaelklishin added a commit that referenced this pull request Apr 23, 2019
Clarify unit symbols

(cherry picked from commit 314b644)
@michaelklishin
Copy link
Collaborator

Cherry-picked to v3.7.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants