Skip to content

Generic queue testing #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 12, 2019
Merged

Generic queue testing #1874

merged 4 commits into from
Feb 12, 2019

Conversation

@dcorbacho
Copy link
Contributor

@dcorbacho dcorbacho commented Feb 11, 2019

Proposed Changes

Move some quorum queue tests to a generic queue type suite.

Added more tests for basic.cancel which must NOT return unacked messages to the queue as implemented by quorum queues. Fixes this too.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@dcorbacho
Move some quorum queue tests to a generic queue type suite.
f800345 
Additional tests for basic.cancel which must NOT return unacked
messages to the queue as implemented by quorum queues.
@dcorbacho
Do not return unacked messages in basic.cancel by quorum queues
7afb62d 
It's not part of the spec. Messages should stay unacked as the consumer
can still ack them, it simply won't receive new messages.
Consumer state should be kept if unacked messages are present, but not listed.
@dcorbacho dcorbacho requested a review from kjnilsson February 11, 2019 17:59
@kjnilsson
rabbif_fifo: refactor and fix tests
fb97086 
Rename rabbit_fifo consumer suspected_down field to status.
@kjnilsson kjnilsson merged commit b0dfe93 into master Feb 12, 2019
@michaelklishin michaelklishin deleted the queues-testing branch March 16, 2019 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

@kjnilsson kjnilsson kjnilsson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dcorbacho @michaelklishin @kjnilsson