Skip to content

Conversation

@ikavgo
Copy link
Contributor

@ikavgo ikavgo commented Feb 12, 2025

rabbit_shovel_dyn_worker_sup_sup doesn't export stop_and_delete_child

It exports stop_child which in turn calls stop_and_delete_child.

Proposed Changes

Please describe the big picture of your changes here to communicate to the RabbitMQ team why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

A pull request that doesn't explain why the change was made has a much lower chance of being accepted.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.

rabbit_shovel_dyn_worker_sup_sup doesn't export stop_and_delete_child

It exports stop_child which in turn calls stop_and_delete_child.
@michaelklishin
Copy link
Collaborator

The current command still does work because

  1. It clears the runtime parameter
  2. The result of the "try stopping child" function is ignored

But I agree that if the interface has changed so must the CLI command.

@michaelklishin michaelklishin changed the title Fix Elixir.RabbitMQ.CLI.Ctl.Commands.DeleteShovelCommand 'ctl delete_shovel': adapt to rabbit_shovel_dyn_worker_sup_sup public API changes Feb 12, 2025
@michaelklishin michaelklishin merged commit 1f9b1ee into main Feb 12, 2025
268 checks passed
@michaelklishin michaelklishin deleted the ik-shovel_delete_fix branch February 12, 2025 19:04
michaelklishin added a commit that referenced this pull request Feb 12, 2025
'ctl delete_shovel':  adapt to rabbit_shovel_dyn_worker_sup_sup public API changes (backport #13244)
michaelklishin added a commit that referenced this pull request Feb 12, 2025
'ctl delete_shovel':  adapt to rabbit_shovel_dyn_worker_sup_sup public API changes (backport #13244) (backport #13252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants