#12557: fall back to system-wide CA certificates (if available) when none are configured for AMQP 1.0 and AMQP 0-9-1 clients such as shovels #12564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Provides a specific function to fix client ssl options, i.e.: apply all fixes that are applied for TLS listeneres and clients on previous versions but also sets `cacerts` option to CA certificates obtained by `public_key:cacerts_get`, only when no `cacertfile` or `cacerts` are provided.
michaelklishin
force-pushed
the
cloudamqp-use-public-key-cacerts-get
branch
from
6086f58 to
3ff7e82
Compare
Collaborator
Author
|
The forced push was a rebase to make sure that #12502 is included (it addresses one specific kind of annoying CT suite flakes). |
michaelklishin
changed the title
This was referenced Oct 22, 2024
michaelklishin
added a commit
that referenced
this pull request
Dec 11, 2024
lukebakken
added a commit
to amazon-mq/upstream-to-rabbitmq-server
that referenced
this pull request
Nov 7, 2025
This uses the same technique as PR rabbitmq#12557 and rabbitmq#12564 to ensure that when neither `cacerts` nor `cacertfile` are set, the system certs are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #12557 by @LoisSotoLopez.