cli enable_feature_flag: --experimental becomes --opt-in #12325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--experimental is no longer particularly fair to Khepri, which is not enabled by default because of its enormous scope, and because once enabled, it cannot be disabled. --opt-in would be a better name but --experimental remains for backwards compatiblity. When both are specified, we consider that the user opts in if at least one of the flags is set to true.
michaelklishin
added a commit
that referenced
this pull request
Sep 18, 2024
cli enable_feature_flag: --experimental becomes --opt-in (backport #12325)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--experimentalis no longer particularly fair to Khepri, which is not enabled by default because of its enormous scope, and because once enabled, it cannot be disabled; it's graduated from its experimental status to a supported feature.--opt-inwould be a better name but--experimentalis still supported for backwards compatibility.When both are specified, we consider that the
user opts in if at least one of the flags is
set to true.