Support SASL mechanism EXTERNAL in Erlang AMQP 1.0 client #11984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In theory, there can be other plugin that offer SASL mechanism EXTERNAL. Therefore, instead of adding a test dependency from app rabbit to app rabbitmq_auth_mechanism_ssl, it's better to test this plugin specific functionality directly in the plugin itself.
michaelklishin
approved these changes
Aug 14, 2024
mergify bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
* Support SASL mechanism EXTERNAL in Erlang AMQP 1.0 client * Move test to plugin rabbitmq_auth_mechanism_ssl In theory, there can be other plugin that offer SASL mechanism EXTERNAL. Therefore, instead of adding a test dependency from app rabbit to app rabbitmq_auth_mechanism_ssl, it's better to test this plugin specific functionality directly in the plugin itself. (cherry picked from commit 60ae4d4)
ansd
added a commit
that referenced
this pull request
Aug 14, 2024
…12003) * Support SASL mechanism EXTERNAL in Erlang AMQP 1.0 client * Move test to plugin rabbitmq_auth_mechanism_ssl In theory, there can be other plugin that offer SASL mechanism EXTERNAL. Therefore, instead of adding a test dependency from app rabbit to app rabbitmq_auth_mechanism_ssl, it's better to test this plugin specific functionality directly in the plugin itself. (cherry picked from commit 60ae4d4) Co-authored-by: David Ansari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.