QQ: refactor and improve leader detection code. #11933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansd
approved these changes
Aug 7, 2024
kjnilsson
force-pushed
the
qq-improve-leader-detection
branch
from
087f083 to
7fd0888
Compare
The leader returned in rabbit_quorum_queue:info/2 only ever queried the pid field from the queue record when more up to date info could have been available in the ra_leaderboard table.
This could happen if a leader election occurred just before the the member removal was initiated. In particular this could happen when stopping and forgetting an existing rabbit node.
kjnilsson
force-pushed
the
qq-improve-leader-detection
branch
from
7fd0888 to
7b5d339
Compare
acogoluegnes
approved these changes
Aug 7, 2024
kjnilsson
added a commit
that referenced
this pull request
Aug 7, 2024
QQ: refactor and improve leader detection code. (backport #11933)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leader returned in rabbit_quorum_queue:info/2 only ever queried the pid field from the queue record when more up to date info could have been available in the ra_leaderboard table.
This PR also improves
rabbit_quorum_queue:shrink_all/1to retry once if cluster change is not permittedThis could happen if a leader election occurred just before the member removal was initiated. In particular this could
happen when stopping and forgetting an existing rabbit node.