Fix unupported modified outcome behaviour #11730
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modified outcome has not been supported in RabbitMQ 3.13 and won't be supported in RabbitMQ 4.0. Specifically, neither in 3.13 nor in 4.0 are any of the modified fields implemented correctly: ``` <field name="delivery-failed" type="boolean"/> <field name="undeliverable-here" type="boolean"/> <field name="message-annotations" type="fields"/> ``` However in 3.13, RabbitMQ pretends to support the modified outcome by including the modified outcome in the `outcomes` field of the `Source`. When the receiver settles with the modified outcome, RabbitMQ either requeues or discards the message depending on some specific modified field combinations. To follow the principle of least surprise, RabbitMQ 4.0 will make it clear in the `outcomes` field of the `Source` in the replying `Attach` frame, that RabbitMQ won't support the modified outcome. If a receiver nevertheless settles with the modified outcome, RabbitMQ will close the session. This is a breaking change in RabbitMQ 4.0. RabbitMQ 3.13 already documents in https://github.com/rabbitmq/rabbitmq-server/tree/v3.13.x/deps/rabbitmq_amqp1_0 that the modified outcome is unsupported. The same should be documented in RabbitMQ 4.0.
|
After feedback from @kjnilsson and having read the full context in #6121 and #6292 and checking that the QPid client indeed still sends a modified outcome in certain scenarios, e.g. in https://github.com/apache/qpid-jms/blob/90eb60f59cb59b7b9ad8363ee8a843d6903b8e77/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsMessageConsumer.java#L464, it's better when RabbitMQ does not cut the connection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modified outcome has not been supported in RabbitMQ 3.13 and won't be supported in RabbitMQ 4.0.
Specifically, neither in 3.13 nor in 4.0 are any of the modified fields implemented correctly:
However in 3.13, RabbitMQ pretends to support the modified outcome by including the modified outcome in the
outcomesfield of theSource. When the receiver settles with the modified outcome, RabbitMQ either requeues or discards the message depending on some specific modified field combinations.To follow the principle of least surprise, RabbitMQ 4.0 will make it clear in the
outcomesfield of theSourcein the replyingAttachframe, that RabbitMQ won't support the modified outcome. If a receiver nevertheless settles with the modified outcome, RabbitMQ will close the session.This is a breaking change in RabbitMQ 4.0.
RabbitMQ 3.13 already documents in
https://github.com/rabbitmq/rabbitmq-server/tree/v3.13.x/deps/rabbitmq_amqp1_0 that the modified outcome is unsupported.
The same should be documented in RabbitMQ 4.0.