This repository was archived by the owner on Nov 17, 2020. It is now read-only.
Make logo lead to /#: it works better with a path_prefix #620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This makes the logo lead to
/#: it works better when amanagement.path_prefixis used.Taking the user to
/with apath_prefixactually works justfine if the
/is accessiable: that will redirect to the prefixed root.However, if
/is not served by the HTTP API (think of a reverse proxyin front of it mediating and controlling access), that will fail.
/#should not suffer from this problem. In fact, that's what the Overview tab has been using for years.Types of Changes
Checklist
CONTRIBUTING.mddocumentFurther Comments
Closes #604.
[#161479342]