Skip to content

Conversation

gustf
Copy link
Contributor

@gustf gustf commented Mar 22, 2021

Proposed Changes

Add support for reading unsigned short "u".

https://www.rabbitmq.com/amqp-0-9-1-errata.html#section_3

@michaelklishin michaelklishin merged commit 0c83dc2 into rabbitmq:master Mar 22, 2021
@michaelklishin
Copy link
Contributor

I'm curious what client you use on the publishing end and why you need this relatively rarely used data type but fair enough :)

@gustf
Copy link
Contributor Author

gustf commented Mar 22, 2021

Hi @michaelklishin

I am using AMQPStorm, https://www.amqpstorm.io
Which in turn are using pamqp, https://pamqp.readthedocs.io/

Writing it here
https://github.com/gmr/pamqp/blob/b269d6f7f3083504931079c6d1f1113ded830f02/pamqp/encode.py#L315

Another thing, just noticed that there is no support for unsigned int either, ok to add a PR for that one also?

@michaelklishin
Copy link
Contributor

@gustf sure.

@acogoluegnes acogoluegnes added this to the 5.12.0 milestone Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants