-
Notifications
You must be signed in to change notification settings - Fork 618
Move BinaryTableValue to public section #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move BinaryTableValue to public section #880
Conversation
|
@BenBorn Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@BenBorn Thank you for signing the Contributor License Agreement! |
michaelklishin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RabbitMQ.Client.client.api is not a namespace used by this client. I don't see any updates to API approval tests either. This needs more work.
|
@michaelklishin I'll wrap this one up this morning. |
Move BinaryTableValue to apiApproval section
4d152a9 to
87bb569
Compare
|
@BenBorn thanks! |
Move BinaryTableValue to public section (cherry picked from commit f088565)
#879
Proposed Changes
Move the BinaryTableValue class to the public section, because its returned by:
'result.BasicProperties.Headers.TryGetValue("key", out object value);'
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply