ra_node: Reset leader_id when starting an election
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
reset-leader_id-when-starting-election
branch
from
ccf7434 to
98caffa
Compare
Before that, we kept the old `leader_id` value around. If the same leader is elected, the `leader_id` remained the same: this prevented the `pending_commands` from being processed in `ra_node_proc:follower_leader_change()`. In the `ra_SUITE:node_recovery()` testcase, this caused a deadlock because the synchronous `gen_statem:call()` in the second `ra:send_and_await_consensus()` never got a reply.
dumbbell
force-pushed
the
reset-leader_id-when-starting-election
branch
from
98caffa to
3d43745
Compare
illotum
pushed a commit
to illotum/ra
that referenced
this pull request
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before that, we kept the old
leader_idvalue around. If the same leader is elected, theleader_idremained the same: this prevented thepending_commandsfrom being processed inra_node_proc:follower_leader_change().In the
ra_SUITE:node_recovery()testcase, this caused a deadlock because the synchronousgen_statem:call()in the secondra:send_and_await_consensus()never got a reply.