Scheduled retention re-evaluation for max_age configured streams #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
changed the title
so that we can stop using list strings for stuff like stream names Make sure stop and delete servers handle both name formats. Also normalise Name to binary inside writer and replica.
This implements periodic re-evaluation of max_age retention specificions so that streams that have little activity but more than one segments will evantually be truncated. Only schedule retention eval if there are multiple segments remaining
Else the passed shared atomic value will be invalid and the first offset won't match the actual first offset available.
kjnilsson
force-pushed
the
scheduled-retention-eval
branch
from
83254a4 to
8c7db3d
Compare
acogoluegnes
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two main changes in this PR:
osiris:name()) support binaries in addition to string lists and use binaries internally.retention_eval_intervalin milliseconds. The default is 1hr. Very small intervals would most likely have unacceptable resource use but there is no lower bound. This also checks that the process that requested retention eval is alive when the request is due to be processed as we won't be able to update the first offset atomic value for streams that have been restarted.Fixes #107