Bump controller-runtime to 0.7 and k8s.io dependencies to v.0.19.2 #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- controller runtime 0.7 has changed leaderlock from ConfigMap to ConfigMapsLeasesResourceLock
- controller runtime helper functions use client.Object in version 0.7
- Reconciler interface has changed in controller runtime 0.7; Reconcile() takes an additional context.Context, which can be used throughout Reconcile() function. - CreateOrUpdate() needs to in client.Client explicitly
- started manager will be stopped when ctx is cancelled
MirahImage
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
There are some breaking changes in this new release of controller runtime and the following commits were to resolve these conflicts/breaking changes:
leases.coordination.k8s.ioinstead of ConfigMap. Related controller runtime change: Change leaderlock fromConfigMaptoConfigMapsLeasesResourceLock⚠ Change leaderlock from ConfigMap to ConfigMapsLeasesResourceLock kubernetes-sigs/controller-runtime#1144Additional Context
Release notes of controller runtime
v0.7has most of the breaking behaviors and necessary user actions documented: https://github.com/kubernetes-sigs/controller-runtime/releasesLocal Testing
Have run unit, integration, and system tests