-
Notifications
You must be signed in to change notification settings - Fork 46
Support original PDF #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support original PDF #180
Conversation
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we should move markup_language to SlideConfiguration from AuthorConfiguraiton before this.
We may use different markup languages over slides.
b0d9a07 to
10dbc08
Compare
I’ve fixed everything else related to this. I’ll make a separate PR for this. |
| "Specify the PDF file to copy when using the pdf markup language.", | ||
| "(must only when --markup-language=pdf)") do |file| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: I18n. I don't know how to do it.
I guess we need to update files under po/.
| end | ||
|
|
||
| def copy_file(from, to) | ||
| Rabbit.logger.info("Copying file: #{from} to #{to}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
|
c026de4 to
c80922f
Compare
c80922f to
d57d2b2
Compare
d57d2b2 to
c645da9
Compare
|
Applied #183. TODO
|
`:pdf` markup language already exists, but we couldn't use it to
use original PDF.
This fix allows us to use `:pdf` markup language to use original
PDF.
Points:
* Add `--readme-markup-language` to manage README format.
* Use `:markdown` for `:pdf`.
* Otherwise, use the same as `--markup-language` by default.
* Backward compatible.
* The source file is `pdf/{id}-{base-name}.pdf`.
* Copy the PDF file specified by the `--pdf` option at initialization.
* Skip `pdf` task to avoid unexpected PDF rebuild.
How to use:
1. `rabbit-slide new --id=foo --base_name=bar --markup-language=pdf --pdf=/path/to/pdf_file ...`
2. Write `README.md`.
3. Edit `config.yaml` if necessary.
4. You can run `rake` to show it or `rake publish` to publish it now.
Co-authored-by: Sutou Kouhei <[email protected]>
c645da9 to
a124f44
Compare
DONE. |

Support original PDF
:pdfmarkup language already exists, but we couldn't use it to use original PDF.This fix allows us to use
:pdfmarkup language to use original PDF.Points:
--readme-markup-languageto manage README format.:markdownfor:pdf.--markup-languageby default.pdf/{id}-{base-name}.pdf.--pdfoption at initialization.pdftask to avoid unexpected PDF rebuild.How to use:
rabbit-slide new --id=foo --base_name=bar --markup-language=pdf --pdf=/path/to/pdf_file ...README.md.config.yamlif necessary.raketo show it orrake publishto publish it now.