My changes #126
My changes #126
Conversation
It seemed weird to me that preStart on postfix was used to generate files not needed directly by postfix and for the self-signed certificate which is also needed by dovecot. nginx.service was also used as a proxy for when ACME certificate generation was done. So I have created mailserver-certificates.target for when certificates are available for other services. For self-signed that means that a new oneshot service called mailserver-selfsigned-certificate has been run. And for ACME this means that the target acme-selfsigned-certificates has been reached (which is when acme has created the self-signed certificates used before the actual certificates provided by LetsEncrypt are created). This setup has the added bonus that if you want to run a service to provide your own certificates you can set that to run before mailserver-certificates.target. DH Parameters are only needed by dovecot so generation of that file has been moved to the dovecot2 preStart. And lastly the only remaining reason to for dovecot to start before postfix was that the auth and lmtp sockets where located in a directory created by postfix. But since they could just as well be located in /run/dovecot2 as long as postfix has access to them I have moved them there.
1. The lowquota test used the wrong fetchmail username and password 2. When running interactively repeatedly mkdir fails since dir exists
As part of r-raymond#61 this moves DKIM handling from rmilter to OpenDKIM.
extraMasterConf is just a string while masterConfig is a nix module so the options are more explicit and has help text.
|
Awesome! Give me some time to look through it. Any additional pair of eyes is very welcome! |
|
Have you considered disabling Travis CI cache so that CI works again? I also believe both Travis and hydra.nixos.org store their cache/files in S3 so caching /nix/store will only be faster for things not built by hydra.nixos.org which this project doesn't have that much of. |
|
@griff Seems you are right. Thanks for the insight :) - Also I think I don't have any complaints about your PR, thanks for the great work! |
|
Testing with master pulled few minutes ago and everything passes (deployment to libvirt and both tests). |
|
@griff just in case you haven't got notifications set up for GitLab, we are discussing this in https://gitlab.com/simple-nixos-mailserver/nixos-mailserver/merge_requests/126. Thanks for your contribution! |
4 participants
Here are the changes discussed in #61
Right now it downloads the ClamAV DB from my domain files.griff.name